Open
Conversation
alice-carr
force-pushed
the
add-feature-report-for-welsh-forms
branch
4 times, most recently
from
c4f3411 to
c61036e
Compare
Add a report to the feature report that shows how many forms have a welsh translation, using the welsh_completed bool from the form. This commit also adds tests for this new report
alice-carr
force-pushed
the
add-feature-report-for-welsh-forms
branch
from
c61036e to
26b320d
Compare
|
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2537.admin.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
alice-carr
changed the title
DavidBiddle
reviewed
Feb 19, 2026
| # FormDocumentsService adds in the welsh_completed details as part of the database query | ||
| form.live_form_document.as_json | ||
| .merge({ | ||
| "welsh_completed" => form.welsh_completed ? true : false, |
Contributor
There was a problem hiding this comment.
I think I'd expect this to be equivalent to:
Suggested change
| "welsh_completed" => form.welsh_completed ? true : false, | |
| "welsh_completed" => form.welsh_completed, |
since form.welsh_completed is already boolean
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
This PR adds a feature report to show how many live or draft forms there are that have a welsh translation
Trello card: https://trello.com/c/garSsQ76/2805-add-feature-report-for-welsh-forms
Things to consider when reviewing