Merged
Conversation
We want to ensure that when a form's questions are changed, we always set the updated_at for that form. This will facilitate us using the updated_at in forms-runner to identify whether a form has changed for different submissions. Co-authored-by: Stephen Daly <[email protected]>
Whenever a change is made to any of the pages or conditions within a form, the save_question_changes! method should always be called on that form. Co-authored-by: Stephen Daly <[email protected]>
|
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2557.admin.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
stephencdaly
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
https://trello.com/c/fMG08XG5/2799-add-job-to-send-an-email-with-a-csv-containing-the-previous-days-submissions
https://trello.com/c/HJEFC3o8/3125-live-forms-can-have-conditions-and-pages-deleted-without-changing-it-to-livewithdraft
Things to consider when reviewing