Skip to content

Comments

Touch form when updating questions#2563

Merged
stephencdaly merged 1 commit intomainfrom
change-form-updated-at-when-changing-questions
Feb 18, 2026
Merged

Touch form when updating questions#2563
stephencdaly merged 1 commit intomainfrom
change-form-updated-at-when-changing-questions

Conversation

@SamJamCul
Copy link
Contributor

If no changes have been made to a form when using save_question_changes! touch the form before calling save! to make sure the new updated_at is set on the draft_form_document.

What problem does this pull request solve?

https://trello.com/c/HJEFC3o8/2842-live-forms-can-have-conditions-and-pages-deleted-without-changing-it-to-livewithdraft

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Do the end to end tests need updating before these changes will pass?
  • Has all relevant documentation been updated?

If no changes have been made to a form when using save_question_changes!
touch the form before calling save! to make sure the new updated_at is
set on the draft_form_document.

Co-authored-by: Stephen Daly <[email protected]>
@sonarqubecloud
Copy link

@github-actions
Copy link

🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2563.admin.review.forms.service.gov.uk/

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

@stephencdaly stephencdaly added this pull request to the merge queue Feb 18, 2026
Merged via the queue into main with commit f3c4fa4 Feb 18, 2026
7 checks passed
@stephencdaly stephencdaly deleted the change-form-updated-at-when-changing-questions branch February 18, 2026 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants