Skip to content

Normalize platforms in Bundler lockfile#1157

Merged
lfdebrux merged 3 commits intomainfrom
ldeb-bundle-normalize-platforms
Jan 28, 2025
Merged

Normalize platforms in Bundler lockfile#1157
lfdebrux merged 3 commits intomainfrom
ldeb-bundle-normalize-platforms

Conversation

@lfdebrux
Copy link
Member

What problem does this pull request solve?

This PR copies over some of the changes alphagov/forms-admin#1727, including bumping the version of Bundler and cleaning up the list of platforms in the lockfile with bundle lock --normalize-platforms.

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Has all relevant documentation been updated?

@lfdebrux lfdebrux force-pushed the ldeb-bundle-normalize-platforms branch from affa43a to bb61817 Compare January 28, 2025 08:15
@lfdebrux lfdebrux enabled auto-merge January 28, 2025 08:15
@sonarqubecloud
Copy link

@lfdebrux lfdebrux merged commit 0d190ce into main Jan 28, 2025
4 checks passed
@lfdebrux lfdebrux deleted the ldeb-bundle-normalize-platforms branch January 28, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants