[WIP] Move detailed guide document #4610
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sairamya93
force-pushed
the
move-detailed-guide-document
branch
3 times, most recently
from
12ba923 to
646fde5
Compare
sairamya93
force-pushed
the
move-detailed-guide-document
branch
3 times, most recently
from
4c1f687 to
d48d04a
Compare
sairamya93
force-pushed
the
move-detailed-guide-document
branch
2 times, most recently
from
43f5f59 to
4b7c911
Compare
sairamya93
force-pushed
the
move-detailed-guide-document
branch
8 times, most recently
from
d87aa8c to
709b9f1
Compare
sairamya93
force-pushed
the
move-detailed-guide-document
branch
3 times, most recently
from
1cf3ec2 to
238be05
Compare
sairamya93
force-pushed
the
move-detailed-guide-document
branch
6 times, most recently
from
29cc0d6 to
87527c2
Compare
- Copied the View from government-frontend - Commit audit trail: https://github.com/alphagov/government-frontend/blob/1503b2907f39e2f11881d5a6c66644792022d549/app/views/content_items/detailed_guide.html.erb
- Added the title - Updated the metadata in the header to fetch from govuk_publishing_components directly - Added the description tag in the header
- Updated the code to retrieve 'title' value directly instead of the method 'title_and_context' - Replaced title with heading component
- Copied over the concern from government-frontend and added the related tests Audit trail: https://github.com/alphagov/government-frontend/blob/596c574714bd821046c77a332c807c9c0d47334b/app/presenters/content_item/national_applicability.rb
- Add cacheable in controller
- As implemented in corporate information pages- https://github.com/alphagov/frontend/blob/main/app/presenters/corporate_information_page_presenter.rb, the contents list are rendered by retrieving the headers from the contend_item and rendering them accordingly
sairamya93
force-pushed
the
move-detailed-guide-document
branch
2 times, most recently
from
8b4e8f4 to
eaaa49a
Compare
sairamya93
force-pushed
the
move-detailed-guide-document
branch
from
eaaa49a to
390c615
Compare
Contributor
Author
|
Closing this PR as it is outdated and opened a new one with these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
To handle the rendering of detailed_guide document type from government_frontend to frontend as part of [RFC 175]
Why
https://trello.com/c/X9bILs3t/444-move-document-type-detailedguide-from-government-frontend-to-frontend
How
Screenshots?