Redirect old csv preview urls #4733
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catalinailie
force-pushed
the
redirect-old-csv-preview-urls
branch
from
595bc55 to
bea909d
Compare
catalinailie
force-pushed
the
redirect-old-csv-preview-urls
branch
from
bea909d to
31e709d
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if draft_asset? && served_from_asset_host? | ||
| redirect_to(Plek.find("draft-assets") + request.path, allow_other_host: true) and return | ||
| if draft_asset? && served_from_origin_host? | ||
| redirect_to(Plek.find("draft-origin", external: true) + request.path, allow_other_host: true) and return |
Check warning
Code scanning / CodeQL
URL redirection from remote source Medium
catalinailie
force-pushed
the
redirect-old-csv-preview-urls
branch
4 times, most recently
from
b602a62 to
96e95a5
Compare
catalinailie
force-pushed
the
redirect-old-csv-preview-urls
branch
3 times, most recently
from
7845b36 to
b5dc9f6
Compare
catalinailie
force-pushed
the
redirect-old-csv-preview-urls
branch
4 times, most recently
from
9435ada to
6024e1c
Compare
After the new /csv-preview URL is in place, we need to redirect asset URLs with /media/…/prefix to the new URL.
When a preview for a draft document is accessed from the origin domain, we want to redirect the url to the draft-origin domain. eg. https://integration.publishing.service.gov.uk/csv-preview/<id>/<filename> should be redirected to https://draft-origin.integration.publishing.service.gov.uk/csv-preview/<id>/<filename>
catalinailie
force-pushed
the
redirect-old-csv-preview-urls
branch
from
73d7de1 to
08b181b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card https://trello.com/c/kwSXPt3Y/3392-redirect-old-asset-csv-preview-urls