Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the links on for Community and Accessibility sections #4307

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

calvin-lau-sig7
Copy link
Contributor

What

Changes identified unclear links on the homepage, root pages and Get Started sections

Why

This more clearly communicates what the link is and where it goes to. Part of #4267.
Note that these changes have mostly been pre-reviewed via our link audit worksheet. There's a few edits that still require edits before push to publish.

  • Accessibility strategy page (links to Nova and Visual Code snippets)
  • Resources and tools page

Copy link

netlify bot commented Nov 15, 2024

You can preview this change here:

Name Link
🔨 Latest commit edf22e2
🔍 Latest deploy log https://app.netlify.com/sites/govuk-design-system-preview/deploys/673b77b89fcc4c00082ac4cf
😎 Deploy Preview https://deploy-preview-4307--govuk-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@owenatgov owenatgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One little blip, otherwise looking sharp as a tack

src/accessibility/accessibility-strategy/index.md Outdated Show resolved Hide resolved
@calvin-lau-sig7
Copy link
Contributor Author

@owenatgov I've flagged in "files changed" the edits that are not approved in the worksheet yet.
If you want to give your 👍 here, I'll update the spreadsheet, and we can consider this fully reviewed (with your approval).

Copy link
Contributor

@owenatgov owenatgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final thing: squash pls

@owenatgov owenatgov force-pushed the edit-link-community-accessibility branch from 3aef502 to edf22e2 Compare November 18, 2024 17:21
@calvin-lau-sig7 calvin-lau-sig7 merged commit 72d3c96 into main Nov 18, 2024
15 checks passed
@calvin-lau-sig7 calvin-lau-sig7 deleted the edit-link-community-accessibility branch November 18, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants