Add content-block-editor to repos.yml #1923
Conversation
| required_status_checks: | ||
| standard_contexts: *standard_security_checks | ||
| additional_contexts: | ||
| - CI |
There was a problem hiding this comment.
This is not going to work since it's a workflow name, while it should be job name.
I suggest adding job names in https://github.com/alphagov/whitehall/tree/main/.github/workflows to use them here to configure branch protection rules (alternatively you can get ids). For workflows that use reusable workflows, the pattern is <initial_workflow.jobs.job.[name/id]> / <reused-workflow.jobs.job.[name/id]>.
There's a lot of examples in other repos.
There was a problem hiding this comment.
Sorted now - see https://github.com/alphagov/content-block-editor/blob/4e0d7e1e8a5b01f5c641a16dfe63107082fd9c7a/.github/workflows/ci.yml#L30 / https://github.com/alphagov/content-block-editor/blob/4e0d7e1e8a5b01f5c641a16dfe63107082fd9c7a/.github/workflows/playwright.yml#L7 and https://github.com/alphagov/content-block-editor/blob/4e0d7e1e8a5b01f5c641a16dfe63107082fd9c7a/.github/workflows/ci.yml#L37 / https://github.com/alphagov/content-block-editor/blob/4e0d7e1e8a5b01f5c641a16dfe63107082fd9c7a/.github/workflows/vitest.yml#L7 👍
There was a problem hiding this comment.
Thanks! This should do the trick.
pezholio
force-pushed
the
add-content-block-editor
branch
from
fb0a07f to
d5f7bdb
Compare
This is a protoype JS library to demonstrate how we could highlight content blocks within publishing apps.