Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GOVUKAPP-1297 Topic header bug #299

Merged
merged 3 commits into from
Mar 14, 2025
Merged

GOVUKAPP-1297 Topic header bug #299

merged 3 commits into from
Mar 14, 2025

Conversation

TimGJD
Copy link
Contributor

@TimGJD TimGJD commented Mar 13, 2025 •
edited
Loading

Fix UI Topic header bug by

  • Only adding blue background when viewmodel has loaded
  • Remove default spacing from VStack (as blue flicker occurring where spacing is)
  • Add padding to account for removal of default VStack spacing (which also corrects the padding on network unavailable and error screens if you see before/after screens below)
Before After
https://github.com/user-attachments/assets/2bd4cf84-b269-4c3b-b1f7-a7cb824c80d8 https://github.com/user-attachments/assets/f6818b5f-aa40-45d3-8256-23cee6d40802
Before After
Before1 After1
Before After
Before2 After2
Before After
Before3 After3

Jira Link

@TimGJD TimGJD marked this pull request as ready for review March 14, 2025 09:32
@TimGJD TimGJD requested a review from a team as a code owner March 14, 2025 09:32
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

1pretz1
1pretz1 approved these changes Mar 14, 2025
View reviewed changes
Copy link
Contributor

@1pretz1 1pretz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TimGJD TimGJD merged commit b9abf79 into develop Mar 14, 2025
9 checks passed
@TimGJD TimGJD deleted the feature/govukapp-1297-topic-header-bug branch March 14, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1pretz1 1pretz1 1pretz1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TimGJD @1pretz1