This repository was archived by the owner on Apr 30, 2021. It is now read-only.
Upgrade prometheus-operator chart #1021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's good to keep things up to date generally, but there's a specific thing I want here: this chart upgrade also upgrades prometheus from 2.13.2 to 2.15.2. Prometheus 2.15 has a feature which considers the WAL size when calculating how much disk it's using (see prometheus/prometheus#5886 ).
Krenair
previously approved these changes
Feb 25, 2020
chrisfarms
previously approved these changes
Feb 25, 2020
This ups prometheus's retentionSize. Now that we're on 2.15, retentionSize needs to include both the tsdb and the WAL. We really don't want it to run out of disk again though so we're leaving a generous headroom 😄
philandstuff
dismissed stale reviews from chrisfarms and Krenair
via
56f2a5d
chrisfarms
approved these changes
Feb 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's good to keep things up to date generally, but there's a specific
thing I want here: this chart upgrade also upgrades prometheus from
2.13.2 to 2.15.2. Prometheus 2.15 has a feature which considers the
WAL size when calculating how much disk it's using (see
prometheus/prometheus#5886 ).