Fix title element merger #92
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add TitleElementMerger processing step to both 10-Q and 10-K parsers - Export TitleElementMerger in processing_steps __init__.py - Include the TitleElementMerger implementation This addresses issues where section titles are split across multiple HTML elements and need to be merged back together (e.g., 'PART I. FINANCI' + 'AL INFORMATION').
- Refactor _can_merge_with_batch to reduce return statements from 7 to 6 - Extract _are_separate_complete_titles helper method for better organization - Fix mypy type errors with proper casting and bool() conversion - All pre-commit checks now pass: tests, linting, and type checking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #63
Added a new TitleElementMerger processing step that identifies and merges adjacent TitleElement instances that:
Tests pass, but it affects the accuracy for the MSFT 10-Q in
task snapshot-verify