Merge pull request #326 from alphaville/kylc/fix-alm-docs-typo #343
alphavilleAnnotations
11 warnings
|
binary comparison to literal `Option::None`:
src/constraints/rectangle.rs#L38
warning: binary comparison to literal `Option::None`
--> src/constraints/rectangle.rs:38:33
|
38 | assert!(xmin != None || xmax != None); // xmin or xmax must be Some
| ^^^^^^^^^^^^ help: use `Option::is_some()` instead: `xmax.is_some()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none
|
|
binary comparison to literal `Option::None`:
src/constraints/rectangle.rs#L38
warning: binary comparison to literal `Option::None`
--> src/constraints/rectangle.rs:38:17
|
38 | assert!(xmin != None || xmax != None); // xmin or xmax must be Some
| ^^^^^^^^^^^^ help: use `Option::is_some()` instead: `xmin.is_some()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none
= note: `#[warn(clippy::partialeq_to_none)]` on by default
|
|
this function has too many arguments (9/7):
src/alm/alm_problem.rs#L135
warning: this function has too many arguments (9/7)
--> src/alm/alm_problem.rs:135:5
|
135 | / pub fn new(
136 | | constraints: ConstraintsType,
137 | | alm_set_c: Option<AlmSetC>,
138 | | alm_set_y: Option<LagrangeSetY>,
... |
144 | | n2: usize,
145 | | ) -> Self {
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
|
|
this function has too many arguments (8/7):
src/alm/alm_factory.rs#L158
warning: this function has too many arguments (8/7)
--> src/alm/alm_factory.rs:158:5
|
158 | / pub fn new(
159 | | f: Cost,
160 | | df: CostGradient,
161 | | mapping_f1: Option<MappingF1>,
... |
166 | | n2: usize,
167 | | ) -> Self {
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: `#[warn(clippy::too_many_arguments)]` on by default
|
|
variable does not need to be mutable:
src/core/panoc/panoc_optimizer.rs#L65
warning: variable does not need to be mutable
--> src/core/panoc/panoc_optimizer.rs:65:27
|
65 | pub fn with_tolerance(mut self, tolerance: f64) -> Self {
| ----^^^^
| |
| help: remove this `mut`
|
|
variable does not need to be mutable:
src/core/fbs/fbs_optimizer.rs#L66
warning: variable does not need to be mutable
--> src/core/fbs/fbs_optimizer.rs:66:9
|
66 | mut self,
| ----^^^^
| |
| help: remove this `mut`
|
= note: `#[warn(unused_mut)]` on by default
|
|
clippy_check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|