Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Important bug fix in ball2 #330

Merged
merged 4 commits into from
Oct 27, 2023
Merged

Important bug fix in ball2 #330

merged 4 commits into from
Oct 27, 2023

Conversation

alphaville
Copy link
Owner

@alphaville alphaville commented Oct 27, 2023 •
edited
Loading

Main Changes

  • Fixed important bug in ball2.rs: the radius was being ignored for balls centered not at the origin
  • Thorough testing
  • New version: 0.8.1

Associated Issues

  • None

TODOs

  • Documentation
  • All tests must pass
  • Update CHANGELOG(s)
  • Update webpage documentation
  • Bump versions (in CHANGELOG, Cargo.toml and VERSION)

@alphaville alphaville added bug Something isn't working rust issue related to the code Rust library labels Oct 27, 2023
@alphaville alphaville self-assigned this Oct 27, 2023
@alphaville alphaville requested review from ruairimoran and removed request for korken89 October 27, 2023 17:42
ruairimoran
ruairimoran approved these changes Oct 27, 2023
View reviewed changes
Copy link
Collaborator

@ruairimoran ruairimoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alphaville alphaville merged commit 8d25f34 into master Oct 27, 2023
10 checks passed
@alphaville alphaville deleted the fix/ball2 branch October 29, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruairimoran ruairimoran ruairimoran approved these changes

Assignees

@alphaville alphaville

Labels
bug Something isn't working rust issue related to the code Rust library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alphaville @ruairimoran