Skip to content

Commit

Permalink
ucm: fix SectionDevice identifiers
Browse files Browse the repository at this point in the history
According [1], the device naming scheme should be consistent.
Try to rename affected device names according the documentation.

[1] https://github.com/alsa-project/alsa-lib/blob/master/include/use-case.h

Signed-off-by: Jaroslav Kysela <[email protected]>
  • Loading branch information
perexg committed Jan 8, 2025
1 parent 247fbc0 commit ea7a065
Show file tree
Hide file tree
Showing 12 changed files with 25 additions and 26 deletions.
2 changes: 1 addition & 1 deletion ucm2/Intel/avs/avs_da7219/avs_da7219-HiFi.conf
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
SectionDevice."Headphone" {
SectionDevice."Headphones" {
Comment "Headphones"

Value {
Expand Down
2 changes: 1 addition & 1 deletion ucm2/Intel/avs/avs_nau8825/avs_nau8825-HiFi.conf
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
SectionDevice."Headphone" {
SectionDevice."Headphones" {
Comment "Headphones"

Value {
Expand Down
4 changes: 2 additions & 2 deletions ucm2/Intel/sof-ehl-rt5660/HiFi.conf
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ SectionDevice."Speaker" {
Comment "Speaker"

ConflictingDevice [
"Lineout"
"Line"
]

EnableSequence [
Expand All @@ -25,7 +25,7 @@ SectionDevice."Speaker" {
}
}

SectionDevice."Lineout" {
SectionDevice."Line" {
Comment "Lineout"

ConflictingDevice [
Expand Down
4 changes: 2 additions & 2 deletions ucm2/Qualcomm/sc8280xp/HiFi.conf
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,8 @@ SectionDevice."Mic" {
}
}

SectionDevice."DMic01" {
Comment "DMic01"
SectionDevice."Mic" {
Comment "Microphone"

Include.vadm0e.File "/codecs/qcom-lpass/va-macro/DMIC0EnableSeq.conf"
Include.vadm0d.File "/codecs/qcom-lpass/va-macro/DMIC0DisableSeq.conf"
Expand Down
4 changes: 2 additions & 2 deletions ucm2/Qualcomm/sm8650/QRD/HiFi.conf
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ SectionDevice."Headphones" {
}
}

SectionDevice."Bottom" {
SectionDevice."Mic1" {
Comment "Bottom Microphone"

Include.wcdmice.File "/codecs/wcd939x/AnalogMic1EnableSeq.conf"
Expand Down Expand Up @@ -82,7 +82,7 @@ SectionDevice."Headset" {
}
}

SectionDevice."Back" {
SectionDevice."Mic2" {
Comment "Back Microphone"

Include.wcdmice.File "/codecs/wcd939x/AnalogMic4EnableSeq.conf"
Expand Down
2 changes: 1 addition & 1 deletion ucm2/Tegra/max98090/HiFi.conf
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ SectionVerb {
]
}

SectionDevice."Speakers" {
SectionDevice."Speaker" {
Comment = "Speakers"

ConflictingDevice [
Expand Down
6 changes: 3 additions & 3 deletions ucm2/Tegra/wm8903/Acer-A500-HiFi.conf
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ SectionVerb {
]
}

SectionDevice."Speakers" {
SectionDevice."Speaker" {
Comment "Speakers"

ConflictingDevice [
Expand Down Expand Up @@ -70,7 +70,7 @@ SectionDevice."Headphones" {
}
}

SectionDevice."InternalMic" {
SectionDevice."Mic" {
Comment "Internal Microphone"

ConflictingDevice [
Expand All @@ -91,7 +91,7 @@ SectionDevice."InternalMic" {
}
}

SectionDevice."HeadsetMic" {
SectionDevice."Headset" {
Comment "Headset Microphone"

ConflictingDevice [
Expand Down
8 changes: 4 additions & 4 deletions ucm2/USB-Audio/BOSS/Katana-HiFi.conf
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ Macro [
}
]

SectionDevice."PrimaryOut" {
SectionDevice."Line1" {
Comment "Music Playback"

Value {
Expand All @@ -45,7 +45,7 @@ SectionDevice."PrimaryOut" {
}
}

SectionDevice."SecondaryOut" {
SectionDevice."Line2" {
Comment "DI Playback"

Value {
Expand All @@ -63,7 +63,7 @@ SectionDevice."SecondaryOut" {
}
}

SectionDevice."PrimaryIn" {
SectionDevice."Line3" {
Comment "Processed Signal"

Value {
Expand All @@ -81,7 +81,7 @@ SectionDevice."PrimaryIn" {
}
}

SectionDevice."SecondaryIn" {
SectionDevice."Line4" {
Comment "DI Capture"

Value {
Expand Down
6 changes: 3 additions & 3 deletions ucm2/USB-Audio/Behringer/Flow8-Recording-Hifi.conf
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ SectionDevice."Line8" {
}


SectionDevice."Line56" {
SectionDevice."Line9" {
Comment "Line-56 L/R"

Value {
Expand All @@ -252,7 +252,7 @@ SectionDevice."Line56" {
}
}

SectionDevice."Line78" {
SectionDevice."Line10" {
Comment "Line-78 L/R"

Value {
Expand All @@ -270,7 +270,7 @@ SectionDevice."Line78" {
}
}

SectionDevice."LineMaster" {
SectionDevice."Line11" {
Comment "Master/Monitor L/R"

Value {
Expand Down
2 changes: 1 addition & 1 deletion ucm2/USB-Audio/Dell/Desktop-Front-Speaker-Headset.conf
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ SectionDevice."Headphones" {
}
}

SectionDevice."Microphone" {
SectionDevice."Mic" {
Comment "Microphone"

Value {
Expand Down
8 changes: 4 additions & 4 deletions ucm2/USB-Audio/Digidesign/Digidesign-Mbox-3-HiFi.conf
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ SectionDevice."Line1" {
}


SectionDevice."line2SPDIF" {
SectionDevice."Line2" {
Comment "SPDIF Out"
Value {
PlaybackPriority 100
Expand All @@ -75,7 +75,7 @@ SectionDevice."line2SPDIF" {
}
}

SectionDevice."mic1" {
SectionDevice."Mic1" {
Comment "Mic/Line 1"

Value {
Expand All @@ -91,7 +91,7 @@ SectionDevice."mic1" {
}
}

SectionDevice."mic2" {
SectionDevice."Mic2" {
Comment "Mic/Line 2"

Value {
Expand All @@ -107,7 +107,7 @@ SectionDevice."mic2" {
}
}

SectionDevice."mic3SPDIF" {
SectionDevice."Mic3" {
Comment "SPDIF In"

Value {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ SectionDevice."Line" {
}
}

SectionDevice."Headphone" {
SectionDevice."Headphones" {
Comment "Headphone Out"
Value {
PlaybackPriority 100
Expand All @@ -49,4 +49,3 @@ SectionDevice."Headphone" {
ChannelPos1 FR
}
}

0 comments on commit ea7a065

Please sign in to comment.