Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix responder header section scroll + increase background contrast of app #2689

Merged
merged 1 commit into from
Nov 2, 2024

Conversation

imolorhe
Copy link
Collaborator

@imolorhe imolorhe commented Nov 2, 2024

fix responder header section scroll (#2688)
increase background contrast of app (#2631)

Fixes

Checks

  • Ran yarn test-build
  • Updated relevant documentations
  • Updated matching config options in altair-static

Changes proposed in this pull request:

Summary by Sourcery

Fix the scrolling issue in the responder header section and enhance the application's background contrast. Update the development documentation with a tip regarding the Angular DevTools extension's impact on performance.

Bug Fixes:

  • Fix the scrolling issue in the responder header section by adding vertical overflow auto property.

Enhancements:

  • Increase the background contrast of the application by adjusting the background opacity.

Documentation:

  • Add a tip in the development documentation about the Angular DevTools extension potentially slowing down the local development application.

increase background contrast of app (#2631)
Copy link

sourcery-ai bot commented Nov 2, 2024

Reviewer's Guide by Sourcery

This PR addresses two issues: improving the scrolling behavior of the responder header section and enhancing the app's visual contrast. The implementation involves a minor CSS adjustment for scrolling and a subtle increase in the background opacity for better contrast. Additionally, development documentation has been updated with performance troubleshooting tips.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Enhanced UI visibility and scrolling behavior
  • Added vertical scroll capability to response headers container
  • Increased background opacity from 0.8 to 0.9 for better contrast
packages/altair-app/src/scss/components/_editor.scss
packages/altair-app/src/scss/_layout.scss
Added development performance troubleshooting documentation
  • Added note about Angular DevTools extension impact on development performance
DEV.md

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @imolorhe - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@@ -145,6 +145,7 @@ app-query-result {

.response-headers__container {
padding: 10px;
overflow-y: auto;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Consider adding overflow-x: auto for handling wide header content

Response headers can sometimes contain long lines. Adding horizontal overflow handling would prevent potential text truncation.

Suggested change
overflow-y: auto;
overflow-x: auto;
overflow-y: auto;

Copy link

github-actions bot commented Nov 2, 2024

Visit the preview URL for this PR (updated for commit 07d78dd):

https://altair-gql--pr2689-imolorhe-fix-respons-76mpblzl.web.app

(expires Sat, 09 Nov 2024 14:01:13 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 02d6323d75a99e532a38922862e269d63351a6cf

@imolorhe imolorhe added this pull request to the merge queue Nov 2, 2024
Merged via the queue into master with commit 423e62e Nov 2, 2024
14 checks passed
@imolorhe imolorhe deleted the imolorhe/fix-response-headers-scroll branch November 2, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Not able to scroll in response headers [BUG] Please fix light theme
1 participant