Skip to content

feat: new DocType "Employment Contract" #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: version-15-hotfix
Choose a base branch
from

Conversation

barredterra
Copy link
Member

@barredterra barredterra commented Oct 15, 2024

Add a new DocType to capture the most relevant data of an employment contract. When changes to the contract occur, we can use cancel + amend to update the contract while leaving a track record.

Bildschirmfoto 2024-10-15 um 12 28 16
Bildschirmfoto 2024-10-15 um 12 28 31
Bildschirmfoto 2024-10-15 um 12 29 00

@0xD0M1M0
Copy link
Contributor

What is the difference to "job-offer" from HRMS?

@barredterra
Copy link
Member Author

barredterra commented Oct 15, 2024

A different trade-off between standardization and flexibility. This doctype tries to model a german employment contract while Job Offer is just a set of arbitrary terms.

@PatrickDEissler
Copy link
Collaborator

PatrickDEissler commented Jun 13, 2025

My Brainstorming:

  • Disadvantage with Cancel + Amend: Employee has no valid Employement Contract for a short time. This might lead to errors, if other functions will rely on a valid Employement Contract in the future.
  • Challenge: Differentiate between instances/companies that use the Employement Contract or simple float fields in Employee to record the working time. Goal: No data redundancy.
  • Vacation per Year: If this won't be used to create Leave Allocations, it will be redundant if Leaves are used in the system.
  • This probably would change the configuration of a Holiday List: Now only proper bank holidays should be in there. (Additional advantage: We could finally automize updation of a Holiday List, since we now have all data we need to do that if there are no weekly offs in the holiday list)

@barredterra
Copy link
Member Author

Let's plan this for version-16, maybe contribute to hrms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants