rc_car_reverse for dshot #166
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: While working this PR I discovered a bug with dshot commands on INAV rover. |
|
Remembering prop_brake_active = 1 is found within instances if use_sine_start and if brake_on_stop. So maybe add warnings for dshot users using these settings to check behavior. Maybe add config setting for user to to disable prop_brake_active for instances outside of rc_car_reverse? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge and release warning
This PR needs extensive testing for all dshot usage.
WARNING!
This adds rc_car_reverse breaking to dshot handling!
This can be especially problematic if rc_car_reverse was erroneously enabled for a 3D aircraft using dshot! If you use bi-directional motors with dshot you must verify all you settings and test this change carefully.
Primary Actions in this PR:
-unblock prop_brake_active for dshot
-duplicate rc_car_reverse for dshot
-use dshot to set prop_brake_duty_cycle when needed
Scanned for and attempted to evaluate for problematic instances of:
prop_brake_active = 1
prop_brake_duty_cycle =