Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Return type-safe messages from useMessages & getMessages #1489

Merged
merged 5 commits into from
Oct 30, 2024

Conversation

amannn
Copy link
Owner

@amannn amannn commented Oct 30, 2024

If consumers use type-safe IntlMessages, these will now be used for useMessages and getMessages.

Fixes #1452

Copy link

vercel bot commented Oct 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-intl-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 3:38pm
next-intl-example-app-router ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 3:38pm
next-intl-example-app-router-without-i18n-routing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 3:38pm

@@ -7,7 +7,7 @@ on:
jobs:
build:
name: Build, lint, and test
runs-on: ubuntu-latest
runs-on: macos-15
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential alternative if this doesn't work well: https://playwright.dev/docs/ci#workers

@amannn amannn merged commit d83abc2 into v4 Oct 30, 2024
6 checks passed
@amannn amannn deleted the feat/strictly-typed-usemessages branch October 30, 2024 15:43
@amannn amannn changed the title feat: Return type-safe IntlMessages from useMessages & getMessages feat: Return type-safe messages from useMessages & getMessages Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant