fix: Change imports to use .js to make them compatible with eslint-plugin-import (#1667)
#1667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@DuckThom is attempting to deploy a commit to the next-intl Team on Vercel. A member of the Team first needs to authorize it. |
amannn
reviewed
Jan 17, 2025
- Forces VSCode to import files following the "module" rule in tsconfig. For ESM emits .js must always be used in imports.
amannn
changed the title
.js to make them compatible with eslint-plugin-import (#1667)
|
@DuckThom Just tried this in your reproduction:
👏👏👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@amannn Following our conversation on X, these are the changes that I've made that appear to be fixing the imports when the
import/namedESLint rule is used.As mentioned before, I also took the liberty of adding the ESLint rule
'import/extensions': 'error'to ensure the right extensions are used in the import/export statements. For context, when compiling to ESM modules, TS copies over the import/export statements as-is, so during development, runtime compatible file extensions must be used.For local testing I ran a build and then manually copied over the
distfolder intonode_modules/next-intlin my other project.