Linux driver update to support FW debug enhancements #453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
VinitAmd
force-pushed
the
fw_logging_support
branch
4 times, most recently
from
d31c1d7 to
ceb5776
Compare
VinitAmd
force-pushed
the
fw_logging_support
branch
2 times, most recently
from
306f4b3 to
53c6e6a
Compare
vengutta18
reviewed
Apr 22, 2025
VinitAmd
force-pushed
the
fw_logging_support
branch
from
53c6e6a to
e1d6c03
Compare
VinitAmd
force-pushed
the
fw_logging_support
branch
from
e1d6c03 to
c6a8763
Compare
VinitAmd
force-pushed
the
fw_logging_support
branch
3 times, most recently
from
8a06edd to
b5b0116
Compare
VinitAmd
changed the title
VinitAmd
changed the title
VinitAmd
force-pushed
the
fw_logging_support
branch
from
b5b0116 to
c828b29
Compare
VinitAmd
commented
May 29, 2025
eble-xilinx
reviewed
May 29, 2025
eble-xilinx
reviewed
May 29, 2025
VinitAmd
force-pushed
the
fw_logging_support
branch
4 times, most recently
from
c12c4c5 to
c3cee05
Compare
eble-xilinx
reviewed
Jun 3, 2025
VinitAmd
force-pushed
the
fw_logging_support
branch
4 times, most recently
from
749225c to
29051f8
Compare
|
ok to test |
|
trigger jenkins |
eble-xilinx
approved these changes
Jun 6, 2025
There was a problem hiding this comment.
@VinitAmd, I focused my review time on interactions with the device firmware. I have no concerns about merging this PR and improving things in a second pass. Thanks for attending to my suggestions.
Add log info to iomapped DRAM buffer from FW, read at driver side on FW triggered interrupts. Signed-off-by: vinit shukla <[email protected]>
VinitAmd
force-pushed
the
fw_logging_support
branch
from
29051f8 to
6f1b17f
Compare
mamin506
approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Why]
DRAM logging support is required to enhance FW debugging.
[What]
Add log info to iomapped DRAM buffer from FW, read at
driver side on FW triggered interrupts.