add note regarding SYSTEM usage for ament_target_dependencies #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bjar Ne <[email protected]>
|
I'm not sure the answer is as clear cut as it was in ROS 1. ROS 2 packages have been using modern CMake targets for a while now, and I can't find the CMake documentation but include directories gotten from imported targets are included as Related to ros2/ros2#1150 |
|
OK, given the fixes and more recent work we've done with overlays (specifically #321 (comment)), I think we should not put this note in. So I'm going to close this one out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in moveit/warehouse_ros#86 and here, using the
SYSTEMdirective for ROS packages inament_target_dependenciesshould be discouraged because of gcc's-isystembehaviour.