Implement ament_add_default_options (#390) #418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Implement ament_add_default_options Signed-off-by: methylDragon <[email protected]> * Mangle cmake_parse_arguments vars Signed-off-by: methylDragon <[email protected]> * Unset macro variables at end Signed-off-by: methylDragon <[email protected]> * Update comment and string Signed-off-by: methylDragon <[email protected]> * Refine macro unsets Signed-off-by: methylDragon <[email protected]>
Author
|
backport of ament_add_default_options . |
Author
|
@mjeronimo Can you comment or accept the PR? |
|
This backport also would be required for making https://github.com/pascalau/vrpn_catkin/tree/ros2 work with ROS 2 Humble. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: methylDragon [email protected]
Signed-off-by: methylDragon [email protected]
Signed-off-by: methylDragon [email protected]
Signed-off-by: methylDragon [email protected]
Signed-off-by: methylDragon [email protected]