Skip to content

Conversation

@rkent
Copy link

@rkent rkent commented Sep 8, 2025

This PR is for testing and demo only.

Tests are added for #587. In addition, a suggested fix is proposed that makes sure that combining a rosidl items (like a /msg folder) do not depend on the order listed in CMakeLists.txt. Specifically, the following is added to ament_python_install_registered_packages.cmake:

  foreach(_dir IN LISTS _PACKAGE_DIRS)
    string(FIND "${_dir}" "rosidl_generator_py" SUBSTRING_INDEX)
    if(NOT SUBSTRING_INDEX EQUAL -1)
      list(REMOVE_ITEM _PACKAGE_DIRS ${_dir})
      list(PREPEND _PACKAGE_DIRS ${_dir})
    endif()
  endforeach()

nadavelkabets and others added 13 commits June 14, 2025 18:35
Signed-off-by: Nadav Elkabets <[email protected]>
Signed-off-by: Nadav Elkabets <[email protected]>
Signed-off-by: Nadav Elkabets <[email protected]>
Signed-off-by: Nadav Elkabets <[email protected]>
Signed-off-by: R Kent James <[email protected]>

Generated-by: Github Copilot v1.364.0
Co-authored-by: R. Kent James <[email protected]>
Co-authored-by Nadav Elkabets <[email protected]>

Signed-off-by: R Kent James <[email protected]>
@rkent rkent force-pushed the rkent-feature-tests branch from 8289f27 to c8eedf2 Compare September 8, 2025 19:43
@rkent
Copy link
Author

rkent commented Oct 22, 2025

This was just a test.

@rkent rkent closed this Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants