Skip to content

Address ament_lint_cmake regressions#604

Merged
ahcorde merged 1 commit intorollingfrom
cottsay/ament-lint-cmake
Nov 11, 2025
Merged

Address ament_lint_cmake regressions#604
ahcorde merged 1 commit intorollingfrom
cottsay/ament-lint-cmake

Conversation

@cottsay
Copy link
Contributor

@cottsay cottsay commented Oct 10, 2025

We don't actively enforce linters in ament_cmake, but it's still nice to be consistent.

Addresses:

$ ament_lint_cmake
ament_cmake_core/cmake/symlink_install/ament_cmake_symlink_install.cmake.in:58: Line ends in whitespace [whitespace/eol]

ament_cmake_export_targets/cmake/ament_export_targets.cmake:25: Line ends in whitespace [whitespace/eol]

ament_cmake_gen_version_h/cmake/ament_generate_version_header.cmake:76: Line ends in whitespace [whitespace/eol]
ament_cmake_gen_version_h/cmake/ament_generate_version_header.cmake:156: Extra spaces between 'if' and its () [whitespace/extra]

ament_cmake_gen_version_h/cmake/generate_version_header.cmake.in:11: Lines should be <= 140 characters long [linelength]

ament_cmake_libraries/cmake/ament_libraries_deduplicate.cmake:33: Lines should be <= 140 characters long [linelength]

ament_cmake_python/test/test_package/CMakeLists.txt:17: Mismatching spaces inside () after command [whitespace/mismatch]


7 errors

@cottsay
Address ament_lint_cmake regressions
fe7d14e 
We don't actively enforce linters in `ament_cmake`, but it's still nice
to be consistent.

Signed-off-by: Scott K Logan <[email protected]>
@cottsay cottsay requested a review from sloretz October 10, 2025 14:53
@cottsay cottsay self-assigned this Oct 10, 2025
@cottsay cottsay added the enhancement New feature or request label Oct 10, 2025
@ahcorde
Copy link
Contributor

ahcorde commented Nov 11, 2025

Pulls: #604
Gist: https://gist.githubusercontent.com/ahcorde/3c7b5564fd9e160856c92e62658b24a7/raw/5f0b2622dfc49f1168de1d60eea1c8d0ad6f20fd/ros2.repos
BUILD args: --packages-up-to ament_cmake_core ament_cmake_export_targets ament_cmake_gen_version_h ament_cmake_libraries --packages-above-and-dependencies ament_cmake_core ament_cmake_export_targets ament_cmake_gen_version_h ament_cmake_libraries
TEST args: --packages-select ament_cmake_core ament_cmake_export_targets ament_cmake_gen_version_h ament_cmake_libraries --packages-above ament_cmake_core ament_cmake_export_targets ament_cmake_gen_version_h ament_cmake_libraries
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17454

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit b681e59 into rolling Nov 11, 2025
3 checks passed
@ahcorde ahcorde deleted the cottsay/ament-lint-cmake branch November 11, 2025 15:32
@ahcorde
Copy link
Contributor

ahcorde commented Nov 11, 2025

https://github.com/Mergifyio backport kilted jazzy humble

@mergify
Copy link

mergify bot commented Nov 11, 2025 •
edited
Loading

backport kilted jazzy humble

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Nov 11, 2025
@cottsay @mergify
Address ament_lint_cmake regressions (#604)
0a4b315 
We don't actively enforce linters in `ament_cmake`, but it's still nice
to be consistent.

Signed-off-by: Scott K Logan <[email protected]>
(cherry picked from commit b681e59)
mergify bot pushed a commit that referenced this pull request Nov 11, 2025
@cottsay @mergify
Address ament_lint_cmake regressions (#604)
f5ff5a7 
We don't actively enforce linters in `ament_cmake`, but it's still nice
to be consistent.

Signed-off-by: Scott K Logan <[email protected]>
(cherry picked from commit b681e59)

# Conflicts:
#	ament_cmake_core/cmake/symlink_install/ament_cmake_symlink_install.cmake.in
mergify bot pushed a commit that referenced this pull request Nov 11, 2025
@cottsay @mergify
Address ament_lint_cmake regressions (#604)
a8f557f 
We don't actively enforce linters in `ament_cmake`, but it's still nice
to be consistent.

Signed-off-by: Scott K Logan <[email protected]>
(cherry picked from commit b681e59)

# Conflicts:
#	ament_cmake_core/cmake/symlink_install/ament_cmake_symlink_install.cmake.in
ahcorde added a commit that referenced this pull request Nov 12, 2025
@mergify @cottsay @ahcorde
Address ament_lint_cmake regressions (backport #604) (#608)
7befbed 
* Address ament_lint_cmake regressions (#604)

We don't actively enforce linters in `ament_cmake`, but it's still nice
to be consistent.

Signed-off-by: Scott K Logan <[email protected]>
(cherry picked from commit b681e59)


Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
Co-authored-by: Scott K Logan <[email protected]>
Co-authored-by: Alejandro Hernandez Cordero <[email protected]>
ahcorde added a commit that referenced this pull request Nov 12, 2025
@mergify @cottsay @ahcorde
Address ament_lint_cmake regressions (backport #604) (#607)
8a2b264 
* Address ament_lint_cmake regressions (#604)

We don't actively enforce linters in `ament_cmake`, but it's still nice
to be consistent.

Signed-off-by: Scott K Logan <[email protected]>
(cherry picked from commit b681e59)

Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
Co-authored-by: Scott K Logan <[email protected]>
Co-authored-by: Alejandro Hernandez Cordero <[email protected]>
ahcorde pushed a commit that referenced this pull request Nov 12, 2025
@mergify @cottsay
Address ament_lint_cmake regressions (#604) (#606)
53f0052 
We don't actively enforce linters in `ament_cmake`, but it's still nice
to be consistent.


(cherry picked from commit b681e59)

Signed-off-by: Scott K Logan <[email protected]>
Co-authored-by: Scott K Logan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahcorde ahcorde ahcorde approved these changes

@sloretz sloretz Awaiting requested review from sloretz

Assignees

@cottsay cottsay

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cottsay @ahcorde