Skip to content

Conversation

@patrick-5546
Copy link

No description provided.

Signed-off-by: Patrick Creighton <[email protected]>
Signed-off-by: Patrick Creighton <[email protected]>
@sloretz
Copy link
Contributor

sloretz commented Nov 2, 2023

This is a nice small PR. Would you be willing to implement it using AMENT_LINT_AUTO_FILE_EXCLUDE instead? (context: #386). That will allow you to filter generated protobuf files at the package level, and also help resolve #458.

Signed-off-by: Patrick Creighton <[email protected]>
@patrick-5546
Copy link
Author

patrick-5546 commented Nov 4, 2023

@sloretz I haven't extensively tested it yet, but does this look something like what you are looking for? I mainly based it off of cpplint's implementation

@patrick-5546
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants