Skip to content

ament_cmake_pep257: handle AMENT_LINT_AUTO_FILE_EXCLUDE #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: rolling
Choose a base branch
from
Open

ament_cmake_pep257: handle AMENT_LINT_AUTO_FILE_EXCLUDE #534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion ament_cmake_pep257/cmake/ament_cmake_pep257_lint_hook.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,17 @@
file(GLOB_RECURSE _python_files FOLLOW_SYMLINKS "*.py")
if(_python_files)
message(STATUS "Added test 'pep257' to check Python code against some of the docstring style conventions in PEP 257")
ament_pep257()

# Get exclude paths for added targets
set(_all_exclude "")
if(DEFINED ament_cmake_pep257_ADDITIONAL_EXCLUDE)
list(APPEND _all_exclude ${ament_cmake_pep257_ADDITIONAL_EXCLUDE})
endif()

if(DEFINED AMENT_LINT_AUTO_FILE_EXCLUDE)
list(APPEND _all_exclude ${AMENT_LINT_AUTO_FILE_EXCLUDE})
endif()

message(STATUS "Configured pep257 exclude dirs and/or files: ${_all_exclude}")
ament_pep257(EXCLUDE ${_all_exclude})
endif()
5 changes: 4 additions & 1 deletion ament_cmake_pep257/cmake/ament_pep257.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
# @public
#
function(ament_pep257)
cmake_parse_arguments(ARG "" "TESTNAME" "" ${ARGN})
cmake_parse_arguments(ARG "" "EXCLUDE;TESTNAME" "" ${ARGN})
if(NOT ARG_TESTNAME)
set(ARG_TESTNAME "pep257")
endif()
Expand All @@ -35,6 +35,9 @@ function(ament_pep257)

set(result_file "${AMENT_TEST_RESULTS_DIR}/${PROJECT_NAME}/${ARG_TESTNAME}.xunit.xml")
set(cmd "${ament_pep257_BIN}" "--xunit-file" "${result_file}")
if(ARG_EXCLUDE)
list(APPEND cmd "--exclude" "${ARG_EXCLUDE}")
endif()
list(APPEND cmd ${ARG_UNPARSED_ARGUMENTS})

file(MAKE_DIRECTORY "${CMAKE_BINARY_DIR}/ament_pep257")
Expand Down