Skip to content

Remove importlib_metadata #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: rolling
Choose a base branch
from
+6 −9
Open

Remove importlib_metadata #564

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fe918da
Remove importlib_metadata
InvincibleRMC Nov 24, 2025
b74c9e1
switch to version guard
InvincibleRMC Nov 25, 2025
e11dc3a
add back default
InvincibleRMC Nov 25, 2025
fd96230
fix flake8
InvincibleRMC Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions ament_copyright/ament_copyright/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,8 @@
# See the License for the specific language governing permissions and
# limitations under the License.

try:
import importlib.metadata as importlib_metadata
except ModuleNotFoundError:
import importlib_metadata
from importlib import metadata
import sys


COPYRIGHT_GROUP = 'ament_copyright.copyright_name'
Expand All @@ -38,8 +36,8 @@

def get_copyright_names():
names = {}
entry_points = importlib_metadata.entry_points()
if hasattr(entry_points, 'select'):
entry_points = metadata.entry_points()
if sys.version_info >= (3, 12):
copyright_groups = entry_points.select(group=COPYRIGHT_GROUP)
else:
copyright_groups = entry_points.get(COPYRIGHT_GROUP, [])
Expand All @@ -53,8 +51,8 @@ def get_copyright_names():

def get_licenses():
licenses = {}
entry_points = importlib_metadata.entry_points()
if hasattr(entry_points, 'select'):
entry_points = metadata.entry_points()
if sys.version_info >= (3, 12):
license_groups = entry_points.select(group=LICENSE_GROUP)
else:
license_groups = entry_points.get(LICENSE_GROUP, [])
Expand Down
1 change: 0 additions & 1 deletion ament_copyright/package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
<author email="[email protected]">Michel Hidalgo</author>

<exec_depend>ament_lint</exec_depend>
<exec_depend>python3-importlib-metadata</exec_depend>

<test_depend>ament_flake8</test_depend>
<test_depend>ament_pep257</test_depend>
Expand Down