adjust for 24 bit flac #940
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed yesterday that when selecting 24-bit flac in the September vrecord release, files were ending up 32-bit. I made a small change, but we should discuss:
(1) Is this the right way to do this? I had to use
-bits_per_raw_sample:ato avoid issues, but I'm not certain this was the right approach. Is dithering something to consider here?(2) Should we consider simply relabeling the user selection menu and sticking with 32-bit? Pros and cons? We did catch this bc the 32-bit flac MKVs were not playing in VLC, but I'm sure that could be resolved.
Thanks!