feat(common.scss): improve code markup#7
Merged
aforsythe merged 1 commit intoampas:mainfrom Nov 19, 2023
Merged
Conversation
mostly visible on dark-themes
Member
|
Thanks @MrLixm |
Member
Contributor
Author
|
Ha crap I missed it. I think it would actually be better to not touch them. Currently, they are being affected by the new changes because the CSS selector is not explicit enough but I would just make sure the change of this PR doesn't affect them, and don't try to change their style as they might be more complex element that just inline code. |
Contributor
Author
|
New PR #8, let me know what you think. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Hello, here is a quick change to improve rendering of inline code markup (
this) for ACES Central.I do think the padding/margin changes are quite subjective so let me know if they are not desirable.
side-effect might be some line breaking earlier than before as this markup is now wider (due to margin and padding)
please note that I did not test the changes directly with discourse so I cannot guarantee that they will work once "deployed"
result
change where previewed using a browser extension to customize CSS per page
here is a "before"
