refactor: modernise config #1394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1394 +/- ##
==========================================
+ Coverage 91.80% 92.07% +0.26%
==========================================
Files 83 84 +1
Lines 1013 1009 -4
==========================================
- Hits 930 929 -1
+ Misses 83 80 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@drainpixie review ping :) |
Nytelife26
added
type: refactor
drainpixie
suggested changes
Jun 12, 2025
Currently, _deepmerge_dicts is fallible when base contains a non-dictionary entry if overrides contains a dictionary entry of the same key. This commit updates the test for deepmerge to include that path.
Fixes a bug where deepmerge was fallible for instances where a non-dictionary entry existed in base that existed as a dictionary in overrides. This rewrite also avoids reassignments, as suggested in review. Co-authored-by: drainpixie <[email protected]>
Co-authored-by: drainpixie <[email protected]>
Co-authored-by: drainpixie <[email protected]>
This outsources path validation to the CLI (click). Co-authored-by: drainpixie <[email protected]>
Co-authored-by: drainpixie <[email protected]>
Co-authored-by: drainpixie <[email protected]>
Nytelife26
commented
Jun 13, 2025
| config_paths = paths.config_paths + ([config_path] if config_path else []) | ||
|
|
||
| for path in config_paths: | ||
| if path.is_file(): |
There was a problem hiding this comment.
This is technically a re-validation for the case where path = config_path via the CLI, but this only occurs once, and I don't think there's a clean way to avoid that.
drainpixie
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
proselint.toolsintoproselint.configPathinstead ofosfunctionsdefault.json)