Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added checks for capitalizing the beginning of sentences #897

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Added checks for capitalizing the beginning of sentences #897

wants to merge 3 commits into from

Conversation

KVGarg
Copy link

@KVGarg KVGarg commented Oct 19, 2018

  1. Fixes Issue Add checks for capitalizing the beginning of sentences. #800
  2. Added a rule( named split_into_sentences) in tools.py that splits the text into sentences and return all the sentences.
  3. Added check in misc.capitalization for checking the beginning of sentences.

Re-modified previous PR #893

KVGarg added 3 commits October 19, 2018 22:50
@KVGarg
Added checks for capitalizing the beginning of sentences
404b6df 
1. Fixes Issue amperser#800
2. Added a rule( named split_into_sentences) in tools.py that splits the text into sentences and return all the sentences.
3. Added check in misc.capitalization for checking the beginning of sentences.
@KVGarg
Minor changes done
cfeb471
@KVGarg
Modified websites rules
96050f2
@Nytelife26 Nytelife26 added the status: awaiting-triage Issues and PRs awaiting investigation and relabelling. label May 29, 2021
@Nytelife26
Copy link
Member

Thank you for your contribution, I regret that I could not review it sooner. I am postponing this for now until the discussion on issue #800 is resolved.

@Nytelife26 Nytelife26 added type: feat Issues and PRs related to new features. priority: low Issues and PRs that should be resolved, but can be postponed. version: minor Issues and PRs with new features belonging to the next minor release. status: postponed Issues and PRs that are being temporarily set aside in favour of others. cat: new-rule Issues and PRs related to new proselint rules. labels Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cat: new-rule Issues and PRs related to new proselint rules. priority: low Issues and PRs that should be resolved, but can be postponed. status: awaiting-triage Issues and PRs awaiting investigation and relabelling. status: postponed Issues and PRs that are being temporarily set aside in favour of others. type: feat Issues and PRs related to new features. version: minor Issues and PRs with new features belonging to the next minor release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KVGarg @Nytelife26