Deprecation for #24

Marked WebsocketCompressionContextFactory argument as deprecated and unused.
amphp · Oct 21, 2023 · 904902c · 904902c
1 parent ec8a6f5
commit 904902c
Showing 1 changed file with 2 additions and 15 deletions.
diff --git a/src/Rfc6455ClientFactory.php b/src/Rfc6455ClientFactory.php
@@ -24,7 +24,8 @@ final class Rfc6455ClientFactory implements WebsocketClientFactory
     use ForbidSerialization;
 
     /**
-     * @param WebsocketCompressionContextFactory|null $compressionContextFactory Use null to disable compression.
+     * @param WebsocketCompressionContextFactory|null $compressionContextFactory Deprecated. This argument is unused.
+     *      Compression is not supported in v3.x but will be in v4.x.
      * @param WebsocketHeartbeatQueue|null $heartbeatQueue Use null to disable automatic heartbeats (pings).
      * @param WebsocketRateLimit|null $rateLimit Use null to disable client rate limits.
      */
@@ -64,24 +65,10 @@ public function createClient(
             }
         }
 
-        $compressionContext = null;
-        if ($this->compressionContextFactory) {
-            $extensions = \array_map('trim', \explode(',', (string) $request->getHeader('sec-websocket-extensions')));
-
-            foreach ($extensions as $extension) {
-                if ($compressionContext = $this->compressionContextFactory->fromClientHeader($extension, $headerLine)) {
-                    /** @psalm-suppress PossiblyNullArgument */
-                    $response->setHeader('sec-websocket-extensions', $headerLine);
-                    break;
-                }
-            }
-        }
-
         return new Rfc6455Client(
             socket: $socket,
             masked: false,
             parserFactory: $this->parserFactory,
-            compressionContext: $compressionContext,
             heartbeatQueue: $this->heartbeatQueue,
             rateLimit: $this->rateLimit,
             frameSplitThreshold: $this->frameSplitThreshold,