feat: add swiftui tap autocapture support #197
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: fix indentation issue (amplitude#188)
PouriaAmini
commented
Jul 18, 2024
| } | ||
|
|
||
| private class _AmplitudeSwiftUIGestureRecognizer: UITapGestureRecognizer {} |
There was a problem hiding this comment.
I've added this to be able to later distinguish the custom gesture recognizer from the others in the window.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support to automatically capture taps on SwiftUI elements that do not fire
UIControlaction methods.New property:
[Amplitude] Target Type: The accessibility trait of the UI element that the user interacted with. Possible values areButton,Link,Image,Search Field,Keyboard Key,Static Text,Header,Tab Bar, andToggle Button.Checklist