Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test files for sender and receiver #60

Merged
merged 1 commit into from
Jul 28, 2020
Merged

Add test files for sender and receiver #60

merged 1 commit into from
Jul 28, 2020

Conversation

ramya-rao-a
Copy link
Collaborator

Description

Brief description of the changes made in the PR. This helps in making better changelog

  • Add the basic open/close tests for sender and receiver based on the patterns used in session.spec.ts and connection.spec.ts files

Reference to any github issues

@ramya-rao-a ramya-rao-a requested a review from chradek July 28, 2020 02:47
chradek
chradek approved these changes Jul 28, 2020
View reviewed changes
Copy link
Collaborator

@chradek chradek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Glad we're getting some more coverage!

@ramya-rao-a ramya-rao-a merged commit 6819ad2 into amqp:master Jul 28, 2020
@ramya-rao-a ramya-rao-a deleted the receiver-test branch July 28, 2020 22:03
@jmealo
Copy link

jmealo commented Nov 20, 2020

@chradek: @ramya-rao-a: I haven't seen anything in terms of an integration test or something that checks for correct behavior using non-mocked connections. Where should I look for those?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chradek chradek chradek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ramya-rao-a @jmealo @chradek