Get c3i working with a successful concourse update with tagging #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. I assume we should hold off on merging this until all the workers are tagged again? |
|
Yep, and we may need to test the resource (for rsync-recipe, etc) yaml generation to make sure that tagging workers won't prevent us from kicking off the resource tasks that pull the recipes off zeus. I think we saw some issues with that once we had all the workers tagged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To ensure we don't break our usual workflow (users don't have to specify --worker-tag in order to kick off general builds), we need a default value for the --worker-tag. The default should be an array with a single value containing the tag that each worker shares.