Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input Hash Forwarding, On chain CU improvements #74

Merged
merged 18 commits into from
Oct 31, 2024
Merged

Input Hash Forwarding, On chain CU improvements #74

merged 18 commits into from
Oct 31, 2024

Conversation

austbot
Copy link
Contributor

@austbot austbot commented Oct 25, 2024 •
edited
Loading

This PR makes on chain execution more efficient, provides a working example, adds a tester to ensure SDK and on chain use cases are working for the simple example and does a little clean up.

@vercel Vercel
Copy link

vercel bot commented Oct 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bonsol ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 5:57pm

@austbot austbot marked this pull request as ready for review October 29, 2024 19:29
jac18281828
jac18281828 requested changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@jac18281828 jac18281828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and thanks for the cleanup. I think the Solana program might have a couple small issues, but otherwise pr seems ready to go

cli/src/execute.rs Outdated Show resolved Hide resolved
cli/src/execute.rs Show resolved Hide resolved
onchain/example-program-on-bonsol/src/lib.rs Show resolved Hide resolved
onchain/example-program-on-bonsol/src/lib.rs Outdated Show resolved Hide resolved
onchain/example-program-on-bonsol/src/lib.rs Outdated Show resolved Hide resolved
onchain/example-program-on-bonsol/src/lib.rs Outdated Show resolved Hide resolved
jac18281828
jac18281828 approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@jac18281828 jac18281828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the cleanup and switching out the base-64 encoding with hex. I think that will be easier for devs to use!

I'd strongly recommend using '0x' as the canonical hex prefix instead of 'hex:' but otherwise this seems ready

cli/src/common.rs Outdated Show resolved Hide resolved
@austbot austbot merged commit 1957812 into main Oct 31, 2024
5 of 6 checks passed
@austbot austbot deleted the forward-inputhash branch October 31, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jac18281828 jac18281828 jac18281828 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@austbot @jac18281828