This repository has been archived by the owner on Feb 2, 2021. It is now read-only.
Added Rx1-Rx2 phase inversion enable enhancement to AD9361 system object. #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfcollins
reviewed
Aug 7, 2019
| @@ -95,6 +95,12 @@ | |||
| isOutput = false; | |||
| end | |||
|
|
|||
| properties (Hidden) | |||
| @@ -95,6 +95,12 @@ | |||
| isOutput = false; | |||
| end | |||
|
|
|||
| properties (Hidden) | |||
| %EnableRx1Rx2PhaseInversion | |||
| % If enabled, RX1 and RX2 are phase aligned | |||
There was a problem hiding this comment.
I would recommend being more specific with this comment. Since it might give a wrong impression
| '', 'EnableRx1Rx2PhaseInversion'); | ||
| obj.EnableRx1Rx2PhaseInversion = value; | ||
| if obj.ConnectedToDevice | ||
| obj.setDebugAttributeLongLong('adi,rx1-rx2-phase-inversion-enable',value); |
There was a problem hiding this comment.
Note that this won't actually update the part unless initialize is called
| @@ -271,7 +286,9 @@ function setupInit(obj) | |||
| obj.setAttributeLongLong(id,'frequency',obj.CenterFrequency ,true,4); | |||
| % Loopback Mode | |||
| obj.setDebugAttributeLongLong('loopback', obj.LoopbackMode); | |||
|
|
|||
| % Enable Rx1-Rx2 Phase Inversion | |||
| obj.setDebugAttributeLongLong('adi,rx1-rx2-phase-inversion-enable', obj.EnableRx1Rx2PhaseInversion); | |||
There was a problem hiding this comment.
This won't do anything unless CustomAGC is enabled
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.