Conversation
792b158 to
7be3866
Compare
nunojsa
left a comment
There was a problem hiding this comment.
here it goes my first round
Documentation/devicetree/bindings/regulator/adi,lt8722-regulator.yaml
Outdated
Show resolved
Hide resolved
Documentation/devicetree/bindings/regulator/adi,lt8722-regulator.yaml
Outdated
Show resolved
Hide resolved
Documentation/devicetree/bindings/regulator/adi,lt8722-regulator.yaml
Outdated
Show resolved
Hide resolved
Documentation/devicetree/bindings/regulator/adi,lt8722-regulator.yaml
Outdated
Show resolved
Hide resolved
Documentation/devicetree/bindings/regulator/adi,lt8722-regulator.yaml
Outdated
Show resolved
Hide resolved
drivers/regulator/lt8722-regulator.c
Outdated
| return ret; | ||
|
|
||
| reg_val &= ~mask; | ||
| reg_val |= (val << __ffs(mask)) & mask; |
There was a problem hiding this comment.
instead of open coding FIELD_PREP(). Can we make sure val is already properly set (in the same way we would pass it to regmap_update_bits()) and then have a one liner:
reg_val = (reg_val & ~mask) | (reg_val & mask);
c5bb8db to
bd3502a
Compare
|
V2: DT Bindings
Kconfig
Driver
|
nunojsa
left a comment
There was a problem hiding this comment.
Looks better. take my inputs and send it upstream... I think it's already good enough to be sent. Of course you'll get more feedback from the maintainers.
Documentation/devicetree/bindings/regulator/adi,lt8722-regulator.yaml
Outdated
Show resolved
Hide resolved
bd3502a to
ce61751
Compare
imply REGULATOR_LT8722. Signed-off-by: Ramon Cristopher M. Calam <ramoncristopher.calam@analog.com>
Add ADI LT8722 full bridge DC/DC converter driver support. Signed-off-by: Ramon Cristopher M. Calam <ramoncristopher.calam@analog.com>
c591733 to
e09f688
Compare
Add documentation for devicetree bindings for LT8722. Signed-off-by: Ramon Cristopher M. Calam <ramoncristopher.calam@analog.com>
e09f688 to
e7e58cf
Compare
|
@rccalam, is this sent? What is the status on this one? |
|
Hi, I'm just checking in on the status of this pull request. Is there anything I can do to help move it forward? |
|
@rccalam Do you plan on having this one done or should I close this? |
PR Description
PR Type
PR Checklist