Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PeriphDrivers): Fix dma_revb & nvic-table.c warnings #1229

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

Brandon-Hurst
Copy link
Contributor

RevB DMA driver had incorrect pointer syntax. NVIC driver had an extern inside a function. These generates errors in CI workflows on third-party repositories which use later version of ARM GCC, even though the files aren't necessarily used by a build. In particular, this is blocking a PR merge due to failing CI on Adafruit's CircuitPython. Since the fixes are simple, it makes sense to just get rid of the warnings here.

adafruit/circuitpython#9667

Description

  • Corrected pointer syntax in dma_revb.c. A couple functions pass srcdst as a pointer instead of a struct. In these cases a '->' instead of a '.' must be used to access members.
  • Moved __isr_vector extern outside of NVIC_SetRAM in nvic_table.c. Later versions of GCC create warnings when externs are placed inside of a function.
  • Added "void" argument to a function prototype in dma_revb.h

@sihyung-maxim
Copy link
Contributor

I don't know why the DMA RevB drivers are included in the SDK when they're not used anywhere... and especially since no development has been done on them since around ~2020, I'm not surprised there were warnings in them. They don't follow the convention for hardware revision files either.

I think it's safe to delete these drivers entirely.

@Brandon-Hurst
Copy link
Contributor Author

Brandon-Hurst commented Oct 15, 2024

Only additional concern not covered by deleting the dma_revb drivers would be the NVIC_Table nested extern. The simple fix for this is to just move the extern to the top of the file. It can be made static as well if needed.
image

@Brandon-Hurst
Copy link
Contributor Author

Removed DMA RevB drivers in latest commit

@sihyung-maxim sihyung-maxim merged commit db69388 into analogdevicesinc:main Oct 24, 2024
9 checks passed
sihyung-maxim pushed a commit to analogdevicesinc/hal_adi that referenced this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants