fix(PeriphDrivers): I2C REVA Inifnite Loop #1263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sihyung-maxim
approved these changes
Nov 11, 2024
sihyung-maxim
pushed a commit
to analogdevicesinc/hal_adi
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed issues in
MXC_I2C_RevA_MasterTransactionwhere after stop condition sent, the code spun on the stop condition send bit being cleared. TheMSTRCTRLstop bit is cleared when the stop condition has started, we spin while that bit is 0, therefore we always spin since it clears instantly, or at least faster than the processor can read it.The original interrupt flag check is wrong too, since it detects when a stop condition occurs. The correct logic is to wait on the send bit until hardware clears it for us. This most likely previously worked because of this line
i2c->intfl0 = MXC_F_I2C_REVA_INTFL0_DONE;. Meaning although "safer" we probably don't need to wait for the stop condition to be sent.Address #1261