fix(Examples): Type overflow in ADC example #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricB-ADI
added
bug
EricB-ADI
assigned EdwinFairchild and Jake-Carter and unassigned Jake-Carter and EdwinFairchild
Jake-Carter
approved these changes
Aug 14, 2023
EdwinFairchild
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
In some driver versions, MXC_ADC_StartConversion directly returns the adc value. However, it may also returns an MXC error which can be negative. The data type of the adc value was unsigned. Therefore, the comparison is always false. This changes the type information such that the comparison can be made.