Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Boards, Examples): Fix MAX32690 GPIO Example #712

Merged
merged 4 commits into from
Aug 17, 2023
Merged

fix(Boards, Examples): Fix MAX32690 GPIO Example #712

merged 4 commits into from
Aug 17, 2023

Conversation

Jake-Carter
Copy link
Contributor

@Jake-Carter Jake-Carter commented Aug 16, 2023 •
edited
Loading

Pull Request Template

Description

Fixes #705

This PR defines weak default handlers for the ports used by the pushbutton and GPIO example on the MAX32690 EVKIT.

The MAX32690 GPIO example has also been updated to be less reliant on these weak handlers, and to be less confusing in general.

Test

GPIO Example now functions on the MAX32690EVKIT (LED1 blinks when PB0 is pressed).

Checklist Before Requesting Review

  • PR Title follows correct guidelines.
  • Description of changes and all other relevant information.
  • (Optional) Link any related GitHub issues using a keyword
  • (Optional) Provide info on any relevant functional testing/validation. For API changes or significant features, this is not optional.

@github-actions github-actions bot added the MAX32690 Related to the MAX32690 (ME18) label Aug 16, 2023
Jacob-Scheiffler
Jacob-Scheiffler reviewed Aug 16, 2023
View reviewed changes
Libraries/Boards/MAX32690/EvKit_V1/Source/board.c Outdated
}

// Default handler for generic GPIO interrupts on port 4 (used by pushbutton)
__weak void GPIO4_IRQHandler(void)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe GPIOWAKE is the interrupt vector for GPIO4.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, removed in e926cf2

@Jake-Carter Jake-Carter merged commit c2a218b into analogdevicesinc:main Aug 17, 2023
9 checks passed
@Jake-Carter Jake-Carter deleted the fix/gh-705 branch August 17, 2023 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jacob-Scheiffler Jacob-Scheiffler Jacob-Scheiffler approved these changes

@sihyung-maxim sihyung-maxim sihyung-maxim approved these changes

Assignees
No one assigned
Labels
MAX32690 Related to the MAX32690 (ME18)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No GPIO IRQ handlers defined for MAX32690 EvKit_V1
3 participants
@Jake-Carter @sihyung-maxim @Jacob-Scheiffler