Skip to content

Datalogger api added #1766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Datalogger api added #1766

wants to merge 3 commits into from

Conversation

liealex
Copy link
Contributor

@liealex liealex commented Oct 16, 2024

No description provided.

@liealex liealex force-pushed the datalogger_api branch 3 times, most recently from 00adc0e to 5fc6e16 Compare October 29, 2024 09:23
@adisuciu adisuciu added the v2.1 label Feb 4, 2025
@IonutMuthi IonutMuthi changed the base branch from dev to main May 28, 2025 05:39
liealex added 2 commits May 28, 2025 09:32
Signed-off-by: Alexandru Lie <[email protected]>
@IonutMuthi IonutMuthi marked this pull request as ready for review June 2, 2025 14:30
@IonutMuthi IonutMuthi requested a review from Copilot June 2, 2025 14:30
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR extends the DataLogger API by adding several new functions to manage tool behavior and display settings. The changes include new API methods such as changeTool, setMinMax, changePrecision, setMinYAxis, and setMaxYAxis; addition of corresponding automated tests in JavaScript; and necessary header updates to support these changes.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
plugins/datalogger/src/datalogger_api.cpp Added new API methods to adjust run state and tool display; new functionality for precision and Y-Axis adjustments.
plugins/datalogger/js/dataLoggerAutomatedTest.js Added automated tests to verify the behavior of the new API methods.
plugins/datalogger/include/datalogger/menus/sevensegmentmonitorsettings.hpp Made DataLogger_API a friend for tighter coupling with monitor settings.
plugins/datalogger/include/datalogger/datalogger_api.hpp Updated the API interface to include new methods introduced in this PR.
Comments suppressed due to low confidence (2)

plugins/datalogger/src/datalogger_api.cpp:147

  • The member name 'sevenSegmetMonitors' appears to be misspelled. It is likely intended to be 'sevenSegmentMonitors'.
monitorTool->sevenSegmetMonitors->togglePeakHolder(enable);

plugins/datalogger/src/datalogger_api.cpp:161

  • The member name 'sevenSegmetMonitors' appears to be misspelled. It is likely intended to be 'sevenSegmentMonitors'.
monitorTool->sevenSegmetMonitors->updatePrecision(decimals);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants