-
Notifications
You must be signed in to change notification settings - Fork 170
gui: Add KDDockWidgets to Scopy plots #1875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Andrei-Fabian-Pop
wants to merge
11
commits into
main
Choose a base branch
from
main_docking_slider
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f6b4a2b
to
a0191b5
Compare
andreidanila1
approved these changes
Jan 28, 2025
a0191b5
to
4e7d075
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 34 out of 36 changed files in this pull request and generated 1 comment.
Files not reviewed (2)
- CMakeLists.txt: Language not supported
- gui/CMakeLists.txt: Language not supported
4e7d075
to
a40fe6d
Compare
1b7d0e9
to
c25ae76
Compare
c25ae76
to
b065bc3
Compare
b065bc3
to
8835656
Compare
Please do not merge this PR before this commit 3ba3e37 is removed |
8835656
to
b505d23
Compare
AlexandraTrifan
approved these changes
Jun 5, 2025
Signed-off-by: Andrei-Fabian-Pop <[email protected]>
Signed-off-by: Andrei-Fabian-Pop <[email protected]>
Signed-off-by: Andrei-Fabian-Pop <[email protected]>
The Qwt XAxis returned a minimumSizeHint that could not be modified when detaching the widget (with KDDockWidgets for example). This meant that the widgets would sometimes exist the viewport. This fixt overrides this and sets a minimumSizeHint of (0, 0). Signed-off-by: Andrei-Fabian-Pop <[email protected]>
Signed-off-by: Andrei-Fabian-Pop <[email protected]>
Signed-off-by: Andrei-Fabian-Pop <[email protected]>
Signed-off-by: Andrei-Fabian-Pop <[email protected]>
Signed-off-by: Andrei-Fabian-Pop <[email protected]>
Signed-off-by: Andrei-Fabian-Pop <[email protected]>
Signed-off-by: Andrei-Fabian-Pop <[email protected]>
On Windows, when detaching a widget from an area with 2 widgets, the plot from said widget will create OpenGL errors. This is because when detaching a widget it might get promoted to a native widget (controlled by windows) and thus losing the "control" of OpenGL. Setting this flag fixes most of these issues by not allowing the promotion unless absolutely necessary. Signed-off-by: Andrei-Fabian-Pop <[email protected]>
9f0d4d8
to
39d4555
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.