Skip to content

gui: Add KDDockWidgets to Scopy plots #1875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

Andrei-Fabian-Pop
Copy link
Contributor

No description provided.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 34 out of 36 changed files in this pull request and generated 1 comment.

Files not reviewed (2)
  • CMakeLists.txt: Language not supported
  • gui/CMakeLists.txt: Language not supported

@Andrei-Fabian-Pop
Copy link
Contributor Author

Please do not merge this PR before this commit 3ba3e37 is removed

The Qwt XAxis returned a minimumSizeHint that could not be modified when
detaching the widget (with KDDockWidgets for example). This meant that
the widgets would sometimes exist the viewport. This fixt overrides this
and sets a minimumSizeHint of (0, 0).

Signed-off-by: Andrei-Fabian-Pop <[email protected]>
Signed-off-by: Andrei-Fabian-Pop <[email protected]>
On Windows, when detaching a widget from an area with 2 widgets,
the plot from said widget will create OpenGL errors. This is
because when detaching a widget it might get promoted to a
native widget (controlled by windows) and thus losing the
"control" of OpenGL. Setting this flag fixes most of these
issues by not allowing the promotion unless absolutely
necessary.

Signed-off-by: Andrei-Fabian-Pop <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants