This repository was archived by the owner on Nov 29, 2023. It is now read-only.
return BigNumber in the case of large number #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've confirmed that this fixes https://github.com/anchorzero/az/issues/2053
though I've also filed an issue on
json-bigint
to see how they will deal with it: sidorares#86 (this also explains the general issue, so is good context for this PR)that said, I think the state of bigint is such that he will probably respond, but it's not that complicated of a function (the upside to all this is that I now understand what is going on much, much better!) and I think it's not the most actively maintained thing ever (eg he hasn't published it in ages)
one downside to this fix is that it exposes BigNumber, which is what they use. I think a next step would be to configure the output type, ideally to be AzDecimal or whatnot