Skip to content

Commit 58d959f

Browse files
committed
fixing compilation errors by rolling back and then adding in depth cutoff parameter again
1 parent 0abe1e7 commit 58d959f

File tree

5 files changed

+10
-17
lines changed

5 files changed

+10
-17
lines changed

src/call_consensus_clustering.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -347,9 +347,9 @@ void cluster_consensus(std::vector<variant> variants, std::string clustering_fil
347347
float solution_error = 0.05;
348348
double quality_threshold = 20;
349349

350-
std::vector<float> error_rate = cluster_error(variants_file, quality_threshold);
351-
float freq_lower_bound = error_rate[0];
352-
float freq_upper_bound = error_rate[1];
350+
double error_rate = cluster_error(variants_file, quality_threshold, depth_cutoff);
351+
float freq_lower_bound = 1-error_rate;
352+
float freq_upper_bound = error_rate;
353353

354354
//read in the cluster values
355355
std::vector<float> means = parse_clustering_results(clustering_file);

src/estimate_error.cpp

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -39,14 +39,13 @@ std::vector<std::vector<uint32_t>> determine_outlier_points(std::vector<double>
3939
return(removal_points);
4040
}
4141

42-
std::vector<float> cluster_error(std::string filename, double quality_threshold){
42+
double cluster_error(std::string filename, double quality_threshold, uint32_t depth_cutoff){
4343
/*
4444
Here we use clustering to determine the value of the noise.
4545
*/
4646

4747
float lower_bound = 0.50;
4848
float upper_bound = 0.99;
49-
uint32_t depth_cutoff = 10;
5049
uint32_t round_val = 4;
5150

5251
std::vector<uint32_t> deletion_positions = find_deletion_positions(filename, depth_cutoff, lower_bound, upper_bound, round_val);
@@ -77,7 +76,7 @@ std::vector<float> cluster_error(std::string filename, double quality_threshold)
7776
count_original += 1;
7877
}
7978

80-
uint32_t n = 2;
79+
uint32_t n = 3;
8180
gaussian_mixture_model model = retrain_model(n, data_original, variants_original, 2, 0.00001);
8281
std::vector<double> means = model.means;
8382

@@ -114,9 +113,5 @@ std::vector<float> cluster_error(std::string filename, double quality_threshold)
114113

115114
//get the upper edge of the noise cluster
116115
auto min_it = std::min_element(cleaned_cluster.begin(), cleaned_cluster.end());
117-
std::cerr << "min it " << *min_it << std::endl;
118-
std::vector<float> tmp;
119-
tmp.push_back(1-(*min_it));
120-
tmp.push_back(*min_it);
121-
return tmp;
116+
return *min_it;
122117
}

src/estimate_error.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,5 @@
33
#include "./include/armadillo"
44
#ifndef estimate_error
55
#define estimate_error
6-
std::vector<float> cluster_error(std::string filename, double quality_threshold);
6+
double cluster_error(std::string filename, double quality_threshold, uint32_t depth_cutoff);
77
#endif

src/gmm.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -959,10 +959,10 @@ std::vector<variant> gmm_model(std::string prefix, std::string output_prefix){
959959
uint32_t round_val = 4;
960960

961961
bool development_mode=true;
962-
std::vector<float> error_rate = cluster_error(prefix, quality_threshold);
962+
double error_rate = cluster_error(prefix, quality_threshold, depth_cutoff);
963963

964-
float lower_bound = error_rate[0]+0.001;
965-
float upper_bound = error_rate[1]-0.001;
964+
float lower_bound = 1-error_rate;
965+
float upper_bound = error_rate;
966966
std::cerr << "lower " << lower_bound << " upper " << upper_bound << std::endl;
967967
std::vector<variant> base_variants;
968968
std::vector<uint32_t> deletion_positions = find_deletion_positions(prefix, depth_cutoff, lower_bound, upper_bound, round_val);

src/saga.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,7 @@
55
#include <numeric>
66
#include <unordered_map>
77
#include <unordered_set>
8-
#include <chrono>
98
#include <tuple>
10-
using namespace std::chrono;
119

1210
void parse_cigar(const bam1_t* read1, std::vector<uint32_t> &positions, std::vector<std::string> &bases, std::vector<uint32_t> &qualities, uint32_t total_ref_pos, uint8_t min_qual){
1311
uint32_t total_query_pos=0;

0 commit comments

Comments
 (0)