Skip to content

Fix tax class in order creation #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 20, 2025
Merged

Fix tax class in order creation #192

merged 1 commit into from
Jan 20, 2025

Conversation

japauliina
Copy link

When creating new order lines, use the tax class that is calculated in PriceList get_price_info method.

Refs TTVA-224

@japauliina
Fix tax class in order creation
c7b0a52 
When creating new order lines, use the tax class that is calculated in
PriceList `get_price_info` method.

Refs TTVA-224
@japauliina japauliina requested a review from jopesy January 17, 2025 12:33
jopesy
jopesy approved these changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@jopesy jopesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great that you found the issue here! Not an easy task since the pricing logic code is quite complex and hard to read. Thanks!

@japauliina japauliina merged commit c8d8179 into tre-varaamo-qa Jan 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jopesy jopesy jopesy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@japauliina @jopesy