TTVA-240 | Change Ceepos cost center code to be based on the tax percentage #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Respa the tax precentage for same product may vary. Ceepos has a different product code for each tax percentage, so we need to get the correct product code based on the tax percentage when sending the order to Ceepos. Change Unit's `cost_center_code` field from CharField to JSONField. This was agreed to be the most straightforward way to implement this feature now. The field then contains a mapping of tax percentages to the correct cost center codes. Refs TTVA-240
japauliina
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Respa the tax precentage for same product may vary. Ceepos has a different product code for each tax percentage, so we need to get the correct product code based on the tax percentage when sending the order to Ceepos.
Change Unit's
cost_center_codefield from CharField to JSONField. This was agreed to be the most straightforward way to implement this feature now. The field then contains a mapping of tax percentages to the correct cost center codes.The migration transforms the current cost center code to default value for all currently used tax percentages.
Refs TTVA-240