Freeing correctly TFormInfo when removed in destructor

[spinettaro]

Once removed during the destructor the form needs to be freed

[andrea-magni]

Hi Daniele, the Remove(LKey) call at line 169, is a call to TFormStand.Remove(ASubject: TSubject) (line 311, same file) that should end up freeing the form object.
What issue are you experiencing and on which platform? I have some suspects on the following IFDEF:

{$IFDEF AUTOREFCOUNT}
  LInfo.DisposeOf;
  LInfo := nil;
{$ELSE}
  LInfo.Free;
{$ENDIF}

I am considering stripping out the first case and to keep the LInfo.Free instruction only.
Let me know your thoughts and thanks for contributing.

[spinettaro]

Ciao Andrea! Sorry for the late response :) What I'm experiencing is a Memory leak when I close the application. I'm testing the application with Win32 configuration. I can also create a simple project if you need it but here you can see the simple steps to reproduce it:

• Create a new project with 2 forms: Form1 and Form2
• Set ReportMemoryLeaksOnShutdown := True;
• Add a button in Form1
• under button click event uses aFormStand.NewAndShow<TForm2>
• close the application

Expected Result:

• The application closes successfully without a memory leak report

Actual Result:

• The application closes with a memory leak report

Let me know

[spinettaro]

oh sorry I missed a piece, I think that is the old code I committed for merge. I think the issue is that there is no check when the Form is created by TFormStand, then the lines you suggested should add a check if the form is owned by LInfo:

{$IFDEF AUTOREFCOUNT}
  LInfo.DisposeOf;
  LInfo := nil;
{$ELSE}
  if LInfo.FormIsOwned then LInfo.Form.Free;
  LInfo.Free;
{$ENDIF}

or create a specific destructor for it