Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Up limits on alias model tris and vertices #353

Closed
wants to merge 0 commits into from

Conversation

4LT
Copy link

@4LT 4LT commented Nov 2, 2024

Doubles the limit on alias model triangles, and doubles the limit on alias model vertices (to nearest power of 2).

Resolves #352

@andrei-drexler
Copy link
Owner

@sezero @j0zzz I think ideally these limits would be increased in QS and JoeQuake as well, to avoid incompatibilities between engines.

@4LT
Copy link
Author

4LT commented Nov 3, 2024

To be quite honest, I don't know why there's a per-model vertex and triangle limit, seems to me there should just be a global limit. Since models are pre-cached as opposed to loaded at runtime, there shouldn't be a negative performance impact from using a growable data structure

Ah, missed the part where MAXALIASTRIS and MAXALIASVERTS are only used for the size of global arrays; in which case it could be replaced with a malloc'd pointer.

@andrei-drexler
Copy link
Owner

Since it doesn't look like the new limits will be adopted by other engines, I went with a different approach in df8f926 - the triangle/vertex limits are gone, and the code just emits QS compatibility warnings for developers instead. The frame limit is still there for now, though.

@mhQuake
Copy link

mhQuake commented Nov 9, 2024

I don't think the old limits are relevant anyway, other than if compatibility with software Quake and the old meshing code is felt important. Other engines should likewise push to remove them.

This is aside from the frame limit, which is protocol-dependent, of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maroooned by MFX+Orl won't load - model w/ too many vertices
3 participants